From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: BUG #3969: pg_ctl cannot detect server startup |
Date: | 2008-02-20 03:05:11 |
Message-ID: | 20080220115149.637F.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-patches |
"ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> Bug reference: 3969
> Description: pg_ctl cannot detect server startup
> Details:
> pg_ctl -w -o "-p 5432 -c max_connections=100" start
> waits for server startup forever and timeout,
> but server has successfully started actually.
I found this bug comes from the definition of WHITESPACE
characters in pg_ctl.c. WHITESPACE is defined as folows:
#define WHITESPACE "\f\n\r\t\v"
In fact, WHITESPACE does not contain whilespace (0x20) :-(
I attach a patch to fix it.
BTW, I also found similar definitions in some places.
(Please grep with "\t\n\r".)
They are a bit different from each other.
For example, whitespaces is defined as " \t\n\r" in tzparser.c.
Is it ok in the inconsistency? Or, should we always use " \f\n\r\t\v" ?
Index: src/bin/pg_ctl/pg_ctl.c
===================================================================
--- src/bin/pg_ctl/pg_ctl.c (HEAD)
+++ src/bin/pg_ctl/pg_ctl.c (working copy)
@@ -49,7 +49,7 @@
typedef long pgpid_t;
-#define WHITESPACE "\f\n\r\t\v" /* as defined by isspace() */
+#define WHITESPACE " \f\n\r\t\v" /* as defined by isspace() */
/* postgres version ident string */
#define PM_VERSIONSTR "postgres (PostgreSQL) " PG_VERSION "\n"
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
WHITESPACE.patch | application/octet-stream | 873 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Maxime Carbonneau | 2008-02-20 05:57:29 | BUG #3972: ERROR: function 59015 returned NULL |
Previous Message | Ricardo David | 2008-02-19 13:10:57 | BUG #3970: ODBC Unknown Sizes Bug? |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2008-02-20 10:29:26 | Re: tzcode update |
Previous Message | Magnus Hagander | 2008-02-19 15:53:40 | Re: Proposed patch to change TOAST compression strategy |