From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Sync our regex code with upstream changes since last time we did |
Date: | 2008-02-16 22:58:29 |
Message-ID: | 200802162258.m1GMwTX16095@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Alvaro Herrera wrote:
> Andrew Dunstan wrote:
> >
> >
> > Tom Lane wrote:
> >> Note that I didn't make any effort to duplicate a lot of cosmetic changes
> >> that they made to bring their copy into line with their own style
> >> guidelines, such as adding braces around single-line IF bodies. Most of
> >> those we either had done already (such as ANSI-fication of function headers)
> >> or there is no point because pgindent would undo the change anyway.
> >
> > Not objecting, but IIRC we disabled the pgindent code that removes
> > braces around single line (or rather statement) IF bodies several years
> > ago.
>
> Yeah, we did, because it was removing the braces around PG_TRY()
> constructs.
We removed it because people didn't like changes to cases like:
if ()
{
a;
}
else
{
b;
}
I don't remember an issue with PG_TRY, which I could have fixed.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-02-16 23:27:34 | pgsql: Move item as done: < > * -Allow AS in "SELECT col AS label" to |
Previous Message | Tom Lane | 2008-02-16 21:51:04 | pgsql: Update docs to reflect the fact that we can now deal with DST |