Re: ALTER INDEX/ALTER TABLE on indexes can cause unrestorable dumps

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: pgsql-bugs(at)postgresql(dot)org, andy(at)tcpd(dot)net
Subject: Re: ALTER INDEX/ALTER TABLE on indexes can cause unrestorable dumps
Date: 2008-01-07 19:16:10
Message-ID: 20080107191610.GI4723@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

dup 3854
thanks

Stefan Kaltenbrunner wrote:

> the reason for this seems to be that pg_dump is using the constraint name
> (which is not changed by ALTER TABLE/ALTER INDEX) and not the index name to
> dump this kind of information but I wonder if it would actually be more
> sensible (until we get ALTER TABLE .. ALTER CONSTRAINT) to simply forbid
> renaming indexes that are part of a constraint like that and hint towards
> ALTER TABLE ADD/DROP CONSTRAINT ?

I think the fix is to make pg_dump emit ALTER TABLE/CLUSTER ON using the
right index name ...

(This makes me wonder whether we should be making pg_dump emit sorted
output for tables with a clustering index.)

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2008-01-07 20:05:15 ALTER INDEX/ALTER TABLE on indexes can cause unrestorable dumps
Previous Message Milen A. Radev 2008-01-07 18:56:18 BUG #3854: pg_dump dumps renamed primary key constraints by their old name