From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Dave Page <dpage(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] buildenv.pl/buildenv.bat |
Date: | 2007-12-19 12:30:24 |
Message-ID: | 20071219123024.GJ11226@svr2.hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Fri, Dec 14, 2007 at 10:47:02AM -0500, Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
> >On Fri, Dec 14, 2007 at 03:39:14PM +0000, Dave Page wrote:
> >
> >>Andrew Dunstan wrote:
> >>
> >>>Writing and calling a temp .bat file might be yucky - having to keep two
> >>>environment files is a lot more yucky, IMNSHO, and we shouldn't make
> >>>people do it.
> >>>
> >>+1
> >>
> >
> >Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do
> >it your way.
> >
> >You need help testing that patch further, or do you consider it ready for
> >application? If so, go.
> >
> >
> >
>
> Yes, please do test it - I don't use buildenv.* at all normally, as then
> buildfarm client takes care of its own environment, and that's what I
> usually use to build on Windows.
It works in my two standalone environments (win32 and win64 machine),
so I've applied the patch now to get full buildfarm testing.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-12-19 12:45:20 | Re: pgwin32_open returning EINVAL |
Previous Message | Andrew Dunstan | 2007-12-19 12:28:19 | Re: Testing mail list |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-12-19 12:54:25 | Re: Doc-patch: PAM authentication fails for local UNIX users |
Previous Message | Magnus Hagander | 2007-12-19 08:40:42 | Re: win32.mak patch |