| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent issue with EXEC_BACKEND-only typedefs |
| Date: | 2007-12-16 10:00:33 |
| Message-ID: | 200712161000.lBGA0Yq02098@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Hi,
>
> It seems pgindent is not considering EXEC_BACKEND typedefs. For
> example,
>
> static void restore_backend_variables(BackendParameters * param, Port *port);
>
> BackendParameters is not considered a typedef.
>
> Not sure how serious an issue this is ... I just noticed and thought I
> would mention it.
Yep. The cause is that find_typedefs actually pulls the typedef out of
the debugged-enabled binary, and on Unix those functions aren't used by
default. This is spelled out in the pgindent/README in CVS.
I could just EXEC_BACKEND in the debug build I use but I suppose there
are other typedef I am missing as well. Any idea on a more
comprehensive solution to finding typedefs?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2007-12-16 10:31:59 | Re: pgwin32_open returning EINVAL |
| Previous Message | Bruce Momjian | 2007-12-16 06:48:22 | Re: psql's describe command (for sequences) output improvement |