Re: [HACKERS] Problem with ControlFileData structure being ABI depe ndent

On Mon, Dec 10, 2007 at 09:56:39AM +0000, Dave Page wrote:
> Dave Page wrote:
> > Tom Lane wrote:
> >> Dave Page <dpage(at)postgresql(dot)org> writes:
> >>> Gregory Stark wrote:
> >>>> An alternative is leaving it in the project file but putting
> >>>> something like
> >>>> this in c.h:
> >>
> >> Put it in win32.h, please. c.h shouldn't get cluttered with
> >> platform-specific kluges when there's no need for it.
> >>
> >> Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?
> >
> > Yeah, the fact that addons may then end up partially compiled with and
> > partially without it being defined. It we just have it error as Greg
> > suggested, then it will force the authors to define it themselves, and
> > if they get that wrong it's their fault not ours.
>
> Patch attached.

Applide with two tiny modifications - the missing quote taht you mentioned,
and changed the #ifdef to only affect MSVC and not mingw.

//Magnus