| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, "Mike C(dot)" <smith(dot)not(dot)western(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #3790: pg_restore error canceling statement due touser request |
| Date: | 2007-12-04 17:05:42 |
| Message-ID: | 20071204170542.GD4727@alvh.no-ip.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Gregory Stark escribió:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
> > This falls in the category of "destabilizing the code for purely
> > cosmetic reasons", and would be a foolish change to make at RC1 time.
>
> I suppose. Expect to have more bug reports like this one then though.
>
> > We could change the text of the ERROR message reasonably easily,
> > but changing the basic transaction abort method is right out.
>
> I fear having a message saying "ERROR This is not an error" is going to get us
> laughed at.
I don't advocate changing that ERROR to anything else. The message
wording, as Tom says, can easily be changed -- I think this patch should
be enough. Feel free to propose better wording.
--
Alvaro Herrera http://www.PlanetPostgreSQL.org/
Voy a acabar con todos los humanos / con los humanos yo acabaré
voy a acabar con todos / con todos los humanos acabaré (Bender)
| Attachment | Content-Type | Size |
|---|---|---|
| av-cancel-msg.patch | text/x-diff | 873 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-12-04 20:54:52 | Re: BUG #3790: pg_restore error canceling statement due to user request |
| Previous Message | Gregory Stark | 2007-12-04 16:54:35 | Re: BUG #3790: pg_restore error canceling statement due touser request |