pgsql: Revert COPY OUT to follow the pre-8.3 handling of ASCII control

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert COPY OUT to follow the pre-8.3 handling of ASCII control
Date: 2007-12-03 00:03:06
Message-ID: 20071203000306.364887540F0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Revert COPY OUT to follow the pre-8.3 handling of ASCII control characters,
namely that \r, \n, \t, \b, \f, \v are dumped as those two-character
representations rather than a backslash and the literal control character.
I had made it do the other to save some code, but this was ill-advised,
because dump files in which these characters appear literally are prone to
newline mangling. Fortunately, doing it the old way should only cost a few
more lines of code, and not slow down the copy loop materially.
Per bug #3795 from Lou Duchez.

Modified Files:
--------------
pgsql/src/backend/commands:
copy.c (r1.289 -> r1.290)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c?r1=1.289&r2=1.290)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-12-03 00:11:01 pgsql: Stamp 8.3beta4.
Previous Message User Conni 2007-12-02 23:00:22 press - pr: added translation of features83.html