| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgwin32_open returning EINVAL |
| Date: | 2007-11-29 11:48:43 |
| Message-ID: | 20071129114843.GG8718@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 28, 2007 at 05:20:46PM +0100, Magnus Hagander wrote:
> On Wed, Nov 28, 2007 at 12:24:26PM -0300, Alvaro Herrera wrote:
> > Martijn van Oosterhout wrote:
> > > On Wed, Nov 28, 2007 at 11:57:35AM -0300, Alvaro Herrera wrote:
> > > > Can we do something like this to report the Win32 error code so that the
> > > > user has a higher chance of figuring out what's going on?
>
> We already do something very similar to what you're donig in
> backend/port/wni32/socket.c :: TranslateSocketError().
>
> So I think it's a good idea to do it, yes.
Thinking about this some more, I think this is a better patch - we already
have a function that takes care of this, including both error and debug
logging. Anybody disagree? If not, I'll go ahead and apply it...
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| win32err.patch | text/plain | 992 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-11-29 12:09:47 | Re: pgwin32_open returning EINVAL |
| Previous Message | Magnus Hagander | 2007-11-29 09:44:12 | Re: Time to update list of contributors |