| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Still a NOTICE in dict_thesaurus.c |
| Date: | 2007-11-28 04:25:07 |
| Message-ID: | 200711280425.lAS4P7D29700@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Thanks, working on this now. Because the stop words can be any stop
> > > word I didn't imagine it could be in the subsitution. What stop word
> > > will it use? Anyway, coding it now to match the left-hand-side.
> >
> > Why would you do that? There is not any corresponding idea of leaving
> > holes in the pattern. AFAICS the only change needed is NOTICE->ERROR.
>
> OK, I see now. The right-hand side just ignores a stop word, rather
> than accepting any stop word. Got it.
>
> So, for the left-hand-side we have '?' as any stop word and a stop word
> as an error, and you want to make a stop word as an error on the
> right-hand-size. No need for '?'. Agreed. Want me to do it?
I have applied the attached patch to change the NOTICE to ERROR. Thanks
for spotting this.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 770 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Treat | 2007-11-28 04:44:34 | Re: Poorly designed tsearch NOTICEs |
| Previous Message | Andrew Dunstan | 2007-11-28 01:57:33 | Re: Quality and Performance |