pgsql: Improve GIN index build's tracking of memory usage by using

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve GIN index build's tracking of memory usage by using
Date: 2007-11-16 21:55:59
Message-ID: 20071116215559.295257540F0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Improve GIN index build's tracking of memory usage by using
GetMemoryChunkSpace, not just the palloc request size. This brings the
allocatedMemory counter close enough to reality (as measured by
MemoryContextStats printouts) that I think we can get rid of the arbitrary
factor-of-2 adjustment that was put into the code initially. Given the
sensitivity of GIN build to work memory size, not using as much of work
memory as we're allowed to seems a pretty bad idea.

Modified Files:
--------------
pgsql/src/backend/access/gin:
ginbulk.c (r1.9 -> r1.10)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginbulk.c?r1=1.9&r2=1.10)
gininsert.c (r1.9 -> r1.10)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/gininsert.c?r1=1.9&r2=1.10)

Browse pgsql-committers by date

  From Date Subject
Next Message User Dpage 2007-11-16 22:03:06 stackbuilder - installers: Update for Slony 1.2.12
Previous Message Tom Lane 2007-11-16 21:50:13 pgsql: GIN index build's allocatedMemory counter needs to be long, not