Re: [HACKERS] Connection Pools and DISCARD ALL

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Connection Pools and DISCARD ALL
Date: 2007-11-10 14:37:38
Message-ID: 200711101437.lAAEbcA19090@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Tom Lane wrote:
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > > Could we maybe have some flavor of ROLLBACK that doesn't issue a warning
> > > if no transaction is in progress? There is precedent for this sort of
> > > facility - DROP ... IF EXISTS.
> >
> > Something that would actually be doable for 8.3 would be to downgrade
> > this particular WARNING to a NOTICE. A DBA who hasn't got
> > log_min_messages set higher than NOTICE hasn't really got a lot of room
> > to whine about bulky logs.
>
> I have developed the attached patch to implement this. I assume we want
> to change ABORT outside a transaction from WARNING to NOTICE, but not
> COMMIT.

Patch applied:

test=> ROLLBACK;
NOTICE: there is no transaction in progress
ROLLBACK

Commit is unchanged:

test=> COMMIT;
WARNING: there is no transaction in progress
COMMIT

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-10 15:40:34 Re: Fix for stop words in thesaurus file
Previous Message Michael Glaesemann 2007-11-10 13:41:49 Re: minimal update

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-11-10 15:40:34 Re: Fix for stop words in thesaurus file
Previous Message Bruce Momjian 2007-11-10 05:06:15 Re: [HACKERS] pg_ctl configurable timeout