Re: Feature Request: inline comments

From: CaT <cat(at)zip(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Feature Request: inline comments
Date: 2007-11-07 23:41:56
Message-ID: 20071107234156.GG8963@zip.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 07, 2007 at 06:32:53PM -0500, Tom Lane wrote:
> CaT <cat(at)zip(dot)com(dot)au> writes:
> > It is a pretty obvious suggestion I bet was made many, many times
> > before, but it would be very useful if you could create comments while
> > creating the objects themselves, like
>
> > CREATE TABLE FOO (
> > ID INTEGER NOT NULL PRIMARY KEY COMMENT 'The ID',
> > VALUE VARCHAR(10) COMMENT 'The value',
> > ) COMMENT 'The table';
>
> This seems like a fairly bad idea to me, because it converts your table
> definitions into proprietary syntax. Heaven help you trying to load the
> above into any other database. With a separate COMMENT ON command, at
> least you have a fighting chance of ignoring the errors and pressing on.

Well, in a dump of the DB, you could have them as COMMENT ON. Otherwise
I /think/ this should do it in vim at least:

:%s/ COMMENT '\([^']*''\)*[^']*'//

It's not a perfect regex (though I think it could be made to hand E''
escaping) but it'll do for most comments.

> > Perhaps this is a small enough add to make it into 8.3?
>
> Feature freeze was six months ago, and no this wouldn't be a "small
> add" even if it was the best idea since sliced bread.

Fair cop.

--
"To the extent that we overreact, we proffer the terrorists the
greatest tribute."
- High Court Judge Michael Kirby

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-11-07 23:50:31 Re: Feature Request: inline comments
Previous Message Andrew Dunstan 2007-11-07 23:38:33 Re: fulltext parser strange behave