pgsql: Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions
Date: 2007-10-13 15:55:58
Message-ID: 20071013155558.51309753E4C@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions of indexes
it affects. The original coding neglected tablespace entirely (causing
the indexes to move to the database's default tablespace) and for an index
belonging to a UNIQUE or PRIMARY KEY constraint, it would actually try to
assign the parent table's reloptions to the index :-(. Per bug #3672 and
subsequent investigation.

8.0 and 8.1 did not have reloptions, but the tablespace bug is present.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
ruleutils.c (r1.207.2.6 -> r1.207.2.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.207.2.6&r2=1.207.2.7)
pgsql/src/backend/utils/cache:
lsyscache.c (r1.129 -> r1.129.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/cache/lsyscache.c?r1=1.129&r2=1.129.2.1)
pgsql/src/include/utils:
lsyscache.h (r1.101 -> r1.101.2.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/lsyscache.h?r1=1.101&r2=1.101.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-10-13 15:56:08 pgsql: Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions
Previous Message Tom Lane 2007-10-13 15:55:49 pgsql: Fix ALTER COLUMN TYPE to preserve the tablespace and reloptions