| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: When telling the bgwriter that we need a checkpoint because too |
| Date: | 2007-10-12 19:39:59 |
| Message-ID: | 20071012193959.335A7753E4C@cvs.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
When telling the bgwriter that we need a checkpoint because too much xlog
has been consumed, recheck against the latest value of RedoRecPtr before
really sending the signal. This avoids useless checkpoint activity if
XLogWrite is executed when we have a very stale local copy of RedoRecPtr.
The potential for useless checkpoint is very much worse in 8.3 because of
the walwriter process (which never does XLogInsert), so while this behavior
was intentional, it needs to be changed. Per report from Itagaki Takahiro.
Modified Files:
--------------
pgsql/src/backend/access/transam:
xlog.c (r1.285 -> r1.286)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.285&r2=1.286)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-13 00:58:04 | pgsql: Teach planagg.c that partial indexes specifying WHERE foo IS NOT |
| Previous Message | Tom Lane | 2007-10-12 18:55:12 | pgsql: Remove hack in pg_tablespace_aclmask() that disallowed |