Re: Skytools committed without hackers discussion/review

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Marko Kreen <markokr(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 15:40:53
Message-ID: 20071010154053.GE18791@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Oct 10, 2007 at 11:30:47AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I also agree with this. We have to pretend it isn't in /contrib now,
> > figure out where want it, then put it there (contrib, pgfoundry, core).
>
> Putting it in core now would mean forcing a post-beta1 initdb, which
> I don't think adequate cause has been shown for.

Ok. In that case, my vote is pgfoundry (heh, I'm sure that's clear by now).
I don't think an adequate cause to break all our procedures to stick it in
core has been shown either.

> Possibly we should sit on the decision for awhile and see if any
> initdb-forcing bugs are reported. But for the moment I think only the
> contrib or pgfoundry options are acceptable.

This sounds like a good fallback - if the option opens up, I really think
it should be put in the backend. (Assuming it's technically sound - I still
haven't checked the actual code, but I'm assuming it's Ok since Jan
approved it)

//Magnus

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Treat 2007-10-10 15:41:56 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Marko Kreen 2007-10-10 15:33:03 Re: Skytools committed without hackers discussion/review

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2007-10-10 15:41:56 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Marko Kreen 2007-10-10 15:33:03 Re: Skytools committed without hackers discussion/review