| From: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgreSQL(dot)org, "Oleg Bartunov" <oleg(at)sai(dot)msu(dot)su>, "Sergey Karpov" <karpov(at)sao(dot)ru> |
| Subject: | Re: Preliminary patch for tsearch example dictionaries/pa rsers in contrib |
| Date: | 2007-10-09 06:23:54 |
| Message-ID: | 200710090823550000@1807128900 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> Given all the flap about txid, this surely mustn't go in without public
> review first ;-). So, here is a submission from Sergey Karpov to fill
> in the lack of any working code examples for user-written tsearch
> parsers and dictionaries.
>
> I will be mostly off-line for the next day or so and don't have time to
> work on this more now, but here are a few comments:
>
> * It seems a bit odd to put multiple independent contrib modules under a
> single subfolder. I'd be inclined to drop the ts_pack layer and just
> make the dictionaries and parser be top-level contrib modules.
Please. Putting multiple modules in the same dir will also break the automatic part of the msvc build parser, requiring special-casing it.
/Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gokulakannan Somasundaram | 2007-10-09 07:25:47 | Re: Including Snapshot Info with Indexes |
| Previous Message | Bruce Momjian | 2007-10-09 03:21:06 | Re: pt_BR FAQ update |