Re: ecpg DllMain fix

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ecpg DllMain fix
Date: 2007-10-03 11:36:23
Message-ID: 20071003113623.GE22596@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, Oct 03, 2007 at 01:13:58PM +0200, Michael Meskes wrote:
> On Wed, Oct 03, 2007 at 12:22:41PM +0200, Magnus Hagander wrote:
> > It passes compile. Rebuilding my full tree now to try to work on making the
> > regression tests actually be able to test it.
>
> Sounds good. :-)

At least we're proceeding.

Going further, all the new threading tests fail on msvc. Haven't
investigated why yet, but will do.

> > > I'm working on an export list atm.
> >
> > Good. I think we want that regardless of things being fixed by removing
> > Dllmain.
>
> Just committed. I also renamed the functions that are not exported to
> make this job easier. Should there be a problem with this it should only
> be a missed rename. However the new sources successfully run through the
> regression suite on my Linux system with and without multithreading.
>
> As for the export list I copied the stuff from libpq, it's untested on
> all other archs.

Ok. I'll take a look at that on msvc when I'm done with the reg tests, but
I'll try to get those running first.

//Magnus

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-10-03 12:27:20 Re: ecpg DllMain fix
Previous Message Michael Meskes 2007-10-03 11:13:58 Re: ecpg DllMain fix