Re: ecpg thread-safe descriptor

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Michael Meskes <meskes(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ecpg thread-safe descriptor
Date: 2007-10-03 08:59:31
Message-ID: 20071003085931.GC30174@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Tue, Oct 02, 2007 at 04:07:06PM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Michael Meskes wrote:
> >> So, does an explicit export list help? If so I'm all for it. There is no
> >> need to export all symbols. I always tried to keep the number of symbols
> >> that get exported but are not needed low. So this will give the best
> >> result possible.
>
> > Yeah, it does seem to fix it.
>
> That's very good news. If Michael can put together an export list
> soon then we'll be in good shape.

I will work on it asap.

> Michael: you should bump the major version number of ecpglib when you do
> this. Removing the not-officially-exported visible symbols *is* an ABI
> break. You may think there isn't anything depending on them, but
> remember how we thought that (twice) for libpq too. Bumping the major
> version number will be cheap insurance against complaints later.

ecpg received a bump from 5 to 6 in this release anyway because of some
other ABI changes, so at least here we're fine. :-)

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-10-03 09:13:27 Re: ecpg DllMain fix
Previous Message Michael Meskes 2007-10-03 08:58:18 Re: ecpg DllMain fix