Re: ecpg thread-safe descriptor

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ecpg thread-safe descriptor
Date: 2007-10-02 19:36:38
Message-ID: 20071002193638.GB25206@feivel.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Tue, Oct 02, 2007 at 02:37:40PM -0400, Tom Lane wrote:
> >> AFAIRC (and hopefully I'm right this time)
> >> multithreading never worked under msvc so we might have to set
> >> thread-safety to disabled on these systems for ecpg for the time being.
>
> If it didn't work then this seems clearly new-feature-development.

Well, ecpg was said to work with multithreading but didn't. However,
since the patch works on most archs if indeed fixes some bugs on those
archs.

> I think Magnus' idea of providing an exports list would be worth trying,
> if someone can try it promptly; failing that, we need to revert this
> patch.

Couldn't we just disable multithreading for Windows resp. MSVC? It
appears to me that the rest of the patch is working as advertized.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Meskes 2007-10-02 19:42:30 Re: ecpg thread-safe descriptor
Previous Message Magnus Hagander 2007-10-02 19:34:52 Re: ecpg thread-safe descriptor