From: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL |
Date: | 2007-10-02 06:42:28 |
Message-ID: | 20071002064145.D9425DCC779@svr2.hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
> > http://www.openssl.org/docs/crypto/ERR_set_mark.html
> > says
> > ERR_set_mark() and ERR_pop_to_mark() were added in OpenSSL 0.9.8.
>
> > Ooops. Back to the drawing board.
>
> To get the buildfarm going again, I applied a patch that turns these
> calls into no-ops if the local OpenSSL hasn't got the functions.
> I'm not entirely sure if the net result is a regression for pre-0.9.8
> OpenSSLs or not --- Magnus, any thoughts on that?
>
I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99 percent of the messages coming out of that
routine, I bet. And things would still work correct in 0.9.8.
/Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-10-02 09:18:23 | Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL |
Previous Message | Magnus Hagander | 2007-10-02 06:22:07 | Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL |
From | Date | Subject | |
---|---|---|---|
Next Message | Brendan Jurd | 2007-10-02 08:35:21 | Re: [HACKERS] Function structure in formatting.c |
Previous Message | Magnus Hagander | 2007-10-02 06:22:07 | Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL |