Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Date: 2007-09-29 11:14:25
Message-ID: 200709291114.l8TBEPk27086@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> That's not fixing the problem, unless your proposal includes never
> >> issuing any warnings at all, for anything.
>
> > No warning for "*" because it is intentional, but warning for actual
> > stop words.
>
> No, you're focusing on one symptom not the problem. The problem is
> that we've got user-visible behavior going on during what's effectively
> a chance event, ie, a cache reload.
>
> One possible real solution would be to tweak the dictionary APIs so
> that the dictionaries can find out whether this is the first load during
> a session, or a reload, and emit notices only in the first case.

Yea, that would work too. Or just throw an error for a stop word in the
file and then you never get a reload (use "*" instead).

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2007-09-29 12:19:16 pgsql: In the release checklist, mention packagers will see the minor
Previous Message Magnus Hagander 2007-09-29 07:15:33 pgsql: Add chklocale.c to pgport files for msvc builds, per buildfarm

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-09-29 13:58:09 Something's been bugging me
Previous Message Magnus Hagander 2007-09-29 06:42:47 Re: PGBuildfarm member skylark Branch HEAD Failed at Stage Make

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-29 14:45:06 Re: OpenSSL Applink
Previous Message Simon Riggs 2007-09-29 07:59:21 set_ps_display during recovery