| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Warning is adjusted of pgbench. |
| Date: | 2007-09-27 09:59:44 |
| Message-ID: | 20070927095944.GB32255@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Thu, Sep 27, 2007 at 03:21:59PM +0900, Hiroshi Saito wrote:
> Hi.
>
> >>To be clear: my thought is to put "#define FRONTEND 1" into
> >>postgres_fe.h and then eliminate ad-hoc definitions of it from a
> >>boatload of Makefiles. A quick grep suggests that the only place this
> >>wouldn't work too well is src/port/, but that could keep on doing what
> >>it's doing.
>
> I tried it. and this is patch of test. Then, I still think that
> consideration is required to a slight degree involving port.
>
> However, This fully satisfied the following tests. (regression test is all
> pass)
>
> FreeBSD
> MinGW(gcc)
> MS-VC8
>
> What do you think?
I will be offline for most of the time for a couple of days, so it will
probably be until early next week before I can look at this. Just a FYI,
but I'll be happy to look at it as soon as I can.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brendan Jurd | 2007-09-27 12:53:06 | Re: Eliminate more detoast copies for packed varlenas |
| Previous Message | Simon Riggs | 2007-09-27 08:09:17 | Re: Hash Index Build Patch |