Re: GUC variable renaming, redux

Tom Lane wrote:
> I wrote:
> > There wasn't any discussion of renaming stats_reset_on_server_start,
> > though logical consistency would seem to require this if we choose
> > a name not starting with stats_ for $merged_var.
>
> Actually ... does stats_reset_on_server_start have a reason to live
> at all? It hardly seems like a behavior that ought to occur on a
> routine basis, and anyone who really wants it can remove the pgstats
> file manually before starting the postmaster.

We also have a stats reset after recovery, and a function to reset it at
the user's whim, so I agree that there doesn't seem to be any reason to
keep it. Neither of these existed when stats_reset_on_server_start was
implemented, IIRC.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.