Re: XLogCacheByte is unused

This has been saved for the 8.4 release:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
> I found XLogCtlData.XLogCacheByte is already unused in CVS HEAD.
> Should we remove the variable, or reserve it for future use?
>
> Index: src/backend/access/transam/xlog.c
> ===================================================================
> --- src/backend/access/transam/xlog.c (revision 1268)
> +++ src/backend/access/transam/xlog.c (working copy)
> @@ -317,7 +317,6 @@
> */
> char *pages; /* buffers for unwritten XLOG pages */
> XLogRecPtr *xlblocks; /* 1st byte ptr-s + XLOG_BLCKSZ */
> - Size XLogCacheByte; /* # bytes in xlog buffers */
> int XLogCacheBlck; /* highest allocated xlog buffer index */
> TimeLineID ThisTimeLineID;
>
> @@ -4115,8 +4114,6 @@
> * Do basic initialization of XLogCtl shared data. (StartupXLOG will fill
> * in additional info.)
> */
> - XLogCtl->XLogCacheByte = (Size) XLOG_BLCKSZ *XLOGbuffers;
> -
> XLogCtl->XLogCacheBlck = XLOGbuffers - 1;
> XLogCtl->Insert.currpage = (XLogPageHeader) (XLogCtl->pages);
> SpinLockInit(&XLogCtl->info_lck);
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +