Re: pgsql: Release the exclusive lock on the table early after truncating it

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Release the exclusive lock on the table early after truncating it
Date: 2007-09-11 00:26:41
Message-ID: 20070911002641.GF3060@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> > Release the exclusive lock on the table early after truncating it in lazy
> > vacuum, instead of waiting till commit.
>
> Weren't you going to disable vacuum_delay in that stretch of code, too?
>
> BTW, not sure if you realized this, but just deleting the
> vacuum_delay_point call is probably a bad idea --- replace it
> with CHECK_FOR_INTERRUPTS() instead.

Hmm, I didn't. Will fix.

Actually, now that you mention it, I remember that Alexey Kluykin (a
colleague from Command Prompt) had already mentioned it to me and I
forgot :-(

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-09-11 03:28:05 pgsql: Rename recently-added pg_stat_activity column from txn_start to
Previous Message Tom Lane 2007-09-11 00:25:06 Re: pgsql: Release the exclusive lock on the table early after truncating it