pgsql: Remove the vacuum_delay_point call in count_nondeletable_pages,

From: alvherre(at)postgresql(dot)org (Alvaro Herrera)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove the vacuum_delay_point call in count_nondeletable_pages,
Date: 2007-09-10 17:58:56
Message-ID: 20070910175856.7D4AF754206@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove the vacuum_delay_point call in count_nondeletable_pages, because we hold
an exclusive lock on the table at this point, which we want to release as soon
as possible. This is called in the phase of lazy vacuum where we truncate the
empty pages at the end of the table.

An alternative solution would be to lower the vacuum delay settings before
starting the truncating phase, but this doesn't work very well in autovacuum
due to the autobalancing code (which can cause other processes to change our
cost delay settings). This case could be considered in the balancing code, but
it is simpler this way.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
pgsql/src/backend/commands:
vacuumlazy.c (r1.61.2.2 -> r1.61.2.3)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/vacuumlazy.c?r1=1.61.2.2&r2=1.61.2.3)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2007-09-10 17:59:03 pgsql: Remove the vacuum_delay_point call in count_nondeletable_pages,
Previous Message Alvaro Herrera 2007-09-10 17:58:51 pgsql: Remove the vacuum_delay_point call in count_nondeletable_pages,