pgsql: Fix breakage of GIN support for varchar[] and cidr[] that I

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix breakage of GIN support for varchar[] and cidr[] that I
Date: 2007-09-03 01:18:33
Message-ID: 20070903011833.BFB1F754201@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix breakage of GIN support for varchar[] and cidr[] that I introduced in the
operator-family rewrite. I had mistakenly supposed that these could use the
pg_amproc entries for text[] and inet[] respectively. However, binary
compatibility of the underlying types does not make two array types binary
compatible (since they must differ in the header field that gives the element
type OID), and so the index support code doesn't consider those entries
applicable. Add back the missing pg_amproc entries, and add an opr_sanity
query to try to catch such mistakes in future. Per report from Gregory
Maxwell.

Modified Files:
--------------
pgsql/src/include/catalog:
catversion.h (r1.420 -> r1.421)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.420&r2=1.421)
pg_amproc.h (r1.67 -> r1.68)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_amproc.h?r1=1.67&r2=1.68)
pgsql/src/test/regress/expected:
opr_sanity.out (r1.77 -> r1.78)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/opr_sanity.out?r1=1.77&r2=1.78)
pgsql/src/test/regress/sql:
opr_sanity.sql (r1.62 -> r1.63)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/opr_sanity.sql?r1=1.62&r2=1.63)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-09-03 01:28:40 pgsql: Add an ORDER BY to nail down the expected row order from a query
Previous Message Tom Lane 2007-09-03 00:39:26 pgsql: Implement function-local GUC parameter settings, as per recent