Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, Gregory Stark <stark(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system
Date: 2007-08-23 17:35:11
Message-ID: 20070823173511.GB31461@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane wrote:
> >> [ shrug... ] This just reinforces my point: if every packager is going
> >> to have his own opinion about how to do it, there's little point in
> >> trying to provide a pre-fab solution.
>
> > Well, there's a point if every packager have his own opinion but the
> > opinions all happen to be equal.
>
> I think we've already found out that the opinions *aren't* equal.
> So far the score seems to be:
> Red Hat: will use relative symlink
> Solaris: will use hardwired path in program
> ???: will use absolute symlink
> Peter's patch supports only the third case, which no packager has yet
> committed to use (though I suppose Debian might like to). It just gets
> in the way for the other two cases.

Sorry, my point is that it is likely that we would be able to use a
hardwired path, because the path is the same in many systems.

Maybe we could turn the configure option into enabling a lookup into
/usr/share/zoneinfo (hardwired). So if the files are there it uses
them. No need to set a symlink of any kind.

It would be even better to use --with-system-tzdata=/usr/share/zoneinfo
which enables lookup in the specified dir, hardwired at compile time in
the executable (I'm not aware if the patch already accepts a path
argument -- seems like the only sane choice). No symlink needed.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-08-23 17:38:30 Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system
Previous Message Tom Lane 2007-08-23 17:19:17 Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-08-23 17:38:10 Re: SQL feature requests
Previous Message Tom Lane 2007-08-23 17:29:53 Re: SQL feature requests