| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | GIT patch |
| Date: | 2007-08-01 03:00:53 |
| Message-ID: | 20070801030053.GA17717@alvh.no-ip.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I've started reading the GIT patch to see if I can help with the review.
First thing I notice is that there are several things that seems left
over; for example the comments in pg_proc for the new functions are
incomplete.
More subtle: in _bt_findinsertloc, the test for
modifiedpage = _bt_groupify() may reset the bit set by the
_bt_vacuum_one_page. Surely it should look like
modifiedpage |= _bt_groupify()
There's also a couple of spots that were not merged cleanly, but since
they were inside comments, the compiler did not complain and so were not
fixed.
I'm also finding a certain lack of code commentary that makes the
reviewing a bit harder.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2007-08-01 03:13:15 | Re: feature suggestion |
| Previous Message | Josh Berkus | 2007-08-01 02:25:02 | Re: feature suggestion |