From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Dave Page <dpage(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] msvc and vista fun |
Date: | 2007-06-26 11:43:53 |
Message-ID: | 20070626114353.GA30733@svr2.hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, Jun 25, 2007 at 03:19:32PM -0400, Andrew Dunstan wrote:
>
>
> I wrote:
> >
> >
> >Would making a change like this in those 12 places be so ugly?
> >
>
> Specifically, I propose the following patch, which should fix the issues
> buildfarm apparently has with the XP command shell (or some incarnations
> of it).
Yeah. Dave has verified taht it's actually because of the XP stuff (he can
repro the failure on XP), so I guess we don't have much choice.
> Strictly speaking, we don't need the changes in builddoc.bat and
> install.bat, but I did them for the sake of completeness. Since it
> should not affect anyone not setting XP_EXIT_FIX it seems fairly low risk.
I've applied it, except for builddoc.bat. Since we didn't send out an
exitcode anyway there, it makes no difference. Left them in install.bat
because there's an actual exitcode there.
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Treat | 2007-06-26 12:18:17 | Re: How do we create the releases? |
Previous Message | ITAGAKI Takahiro | 2007-06-26 11:19:22 | pgstat_drop_relation bugfix |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2007-06-26 13:57:39 | Re: Load Distributed Checkpoints, take 3 |
Previous Message | ITAGAKI Takahiro | 2007-06-26 11:19:22 | pgstat_drop_relation bugfix |