From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: remove unused "caller" arg from stringToQualifiedNameList |
Date: | 2007-06-25 18:25:31 |
Message-ID: | 20070625182531.GC15627@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > This function seems to have an argument that is no longer used (probably
> > leftover from when it used to report an error message?).
>
> Yeah, I recall having left the argument in place because it seemed like
> we might want it again someday. But that was for 7.4 which was awhile
> ago. There's probably not a strong argument to keep it, but on the
> other hand is there a strong argument to remove it?
Other than removing cruft, nope, I don't see any ...
In any case, this is an exported symbol so maybe it's not a good idea to
mess with it. OTOH I checked PL/R and PL/php and neither uses it, so
this may not be a problem at all.
--
Alvaro Herrera http://www.flickr.com/photos/alvherre/
"The ability to monopolize a planet is insignificant
next to the power of the source"
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-06-25 19:02:40 | remove SIBackendInit return value |
Previous Message | Tom Lane | 2007-06-25 17:48:08 | Re: remove unused "caller" arg from stringToQualifiedNameList |