Re: Padding on 64-bit

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Padding on 64-bit
Date: 2007-05-30 20:26:13
Message-ID: 200705302026.l4UKQDe01510@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Magnus Hagander wrote:
> >> I think that's backwards. We *are* passing them by reference, we should
> >> be considering passing them by value.
>
> > Thanks, fixed.
>
> Also, the TODO item ought to mention float4 and float8, which IMHO ought
> to be changed at the same time. float4 could become pass-by-val-always.
> I think the main reason we've avoided that is to avoid breaking old code
> that is not using DatumGet/GetDatum macros, but we'll be breaking most
> such code anyway with this set of changes.

Update:

* Consider allowing 64-bit integers and floats to be passed by value on
64-bit platforms

Also change 32-bit floats (float4) to be passed by value at the same
time.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-05-30 20:27:40 Re: Ye olde drop-the-database-you-just-left problem
Previous Message Tom Lane 2007-05-30 20:21:02 Re: Padding on 64-bit