From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Remove ruleutils.c's use of varnoold/varoattno as a shortcut for |
Date: | 2007-05-24 18:58:42 |
Message-ID: | 20070524185842.B17389FB8AC@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Remove ruleutils.c's use of varnoold/varoattno as a shortcut for determining
what a Var node refers to. This is no longer necessary because the new
flat-range-table representation of plan trees makes it relatively easy to dig
down through child plan levels to find the original reference; and to keep
doing it that way, we'd have to store joinaliasvars lists in flattened RTEs,
as demonstrated by bug report from Leszek Trenkner. This change makes
varnoold/varoattno truly just debug aids, which wasn't quite the case before.
Perhaps we should drop them, or only have them in assert-enabled builds?
Modified Files:
--------------
pgsql/src/backend/utils/adt:
ruleutils.c (r1.257 -> r1.258)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.257&r2=1.258)
From | Date | Subject | |
---|---|---|---|
Next Message | User Eggyknap | 2007-05-25 04:41:22 | pgsnmpd - pgsnmpd: Update TODO |
Previous Message | Tom Lane | 2007-05-24 18:54:10 | pgsql: Avoid assuming that the fields of struct timeval have exactly |