| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Clear up strxfrm() in UTF-8 with locale on Windows |
| Date: | 2007-05-03 07:31:31 |
| Message-ID: | 20070503073131.GA17603@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Wed, May 02, 2007 at 05:25:39PM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Given this, perhaps the proper approach should instead be to just check
> > the return value, and go from there? Should be a simple enough patch,
> > something like the attached.
>
> > Tom, can you comment?
>
> Testing against INT_MAX seems like a type pun, or something. Maybe use
> MaxAllocSize instead?
The windows API documentation specifically says:
On an error, each function sets errno and returns INT_MAX.
So actually an equality test against INT_MAX would be correct. But making
that clear in the comment would probably not be a bad idea :-)
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-05-03 11:57:26 | Re: Updated bitmap index patch |
| Previous Message | Tom Lane | 2007-05-03 06:32:20 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |