Re: autovacuum multiworkers, patch 5

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: autovacuum multiworkers, patch 5
Date: 2007-04-12 10:27:37
Message-ID: 20070412192004.0C1A.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:

> > > I manually merged your patch on top of my own. This is the result.
> > > Please have a look at whether the new code is correct and behaves sanely
> > > (I haven't tested it).
>
> Huh, you are right, it is broken, even in my outgoing mailbox -- I don't
> know what happened, as the file I have on disk is complete. Here is
> attached again.

I tested your patch on Linux and Windows. It works well on Linux,
where we use fork(), but falls into segfault on Windows, where we
use exec(). Maybe you forgot to initialize the shared memory stuff.
(I haven't find out where to be fixed, sorry.)

Multiworker and balancing seem to work well after they successfully start up.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2007-04-12 10:57:17 Re: Automatic adjustment of bgwriter_lru_maxpages
Previous Message Jacky Leng 2007-04-12 10:20:36 Do we still need "log_invalid_page"?

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-04-12 10:57:17 Re: Automatic adjustment of bgwriter_lru_maxpages
Previous Message Heikki Linnakangas 2007-04-12 08:40:19 Re: [HACKERS] Fix mdsync never-ending loop problem