Re: PL/Python warnings in CVS HEAD

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Python warnings in CVS HEAD
Date: 2007-04-04 17:28:12
Message-ID: 200704041728.l34HSCU15712@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Patch applied. Thanks.

---------------------------------------------------------------------------

Marko Kreen wrote:
> On 4/3/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Great, patch applied and TODO item removed.
>
> If you are already patching, please apply the following patch also.
>
> It removes last remaining casts inside struct definitions.
> Such usage is bad practice, as it hides problems from compiler.
>
> Reason for the cast is popular practice in some circles
> to define functions as foo(MyObj *) instead of foo(PyObject *)
> thus avoiding a local variable inside functions and make
> direct calling easier. As pl/python does not use such style,
> the casts were unnecessary from the start.
>
> --
> marko

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zoltan Boszormenyi 2007-04-04 17:44:16 Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch
Previous Message Jeff Davis 2007-04-04 17:23:49 Re: Synchronized Scan benchmark results