Re: PL/Python warnings in CVS HEAD

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <neilc(at)samurai(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Python warnings in CVS HEAD
Date: 2007-04-02 23:00:36
Message-ID: 200704022300.l32N0ak15450@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Where are we on Python 2.5?

---------------------------------------------------------------------------

Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> >> No, it just looks like a Python API 2.5 change to me
>
> > Attached is a patch that fixes the warnings. Unfortunately, it seems
> > this patch won't compile against Python 2.4: the 2.5 API requires the
> > use of some typedef's that AFAICS were only introduced in 2.5.
>
> > Since we presumably still want to support Python < 2.5, we can either
> > not apply this patch and tolerate the warnings, or else we can
> > workaround the incompatibility with some preprecessor hackery (e.g.
> > supply the missing typedef's ourselves if Python doesn't provide them).
>
> Sounds like #ifdef time to me --- but it seems a bit strange; wouldn't
> the Python guys have taken a bit more care for compatibility of
> user-supplied code? We're hardly the only people who want to support
> multiple Python versions. Perhaps they provide a compatibility hack
> that you didn't spot?
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-04-02 23:06:11 Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous Message Bruce Momjian 2007-04-02 22:57:44 Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for