Re: Server-side support of all encodings

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Server-side support of all encodings
Date: 2007-03-26 09:42:22
Message-ID: 20070326.184222.112627760.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Backend encodings must have the property
> >> that all bytes of a multibyte character are >= 128.
>
> > But then, PG_JOHAB have already infringed it. Please see johab_to_utf8.map.
> > Trailing bytes of JOHAB can be less than 128.
>
> In that case we must remove JOHAB from the list of allowed server
> encodings. Tatsuo, can you comment on whether this is correct?

Sigh. From the first day when JOHAB was supported (back to 7.3 days),
it should had not been in the server encodings. JOHAB's second byte
definitely contain 0x41 and above. *johab*.map just reflect the
fact. I think we should remove JOHAB from the server encodings list.
I'm afraid users who have JOHAB encoded databases get angry, though.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2007-03-26 10:32:26 Re: tsearch2 regression test failures
Previous Message Zoltan Boszormenyi 2007-03-26 09:38:09 Re: Crash bug in 8.2.3 on Solaris 10/Sparc