From: | "Dave Page" <dpage(at)postgresql(dot)org> |
---|---|
To: | mha(at)postgresql(dot)org (MagnusHagander) |
Cc: | pgsql-committers(at)postgresql(dot)org, mha(at)hagander(dot)net |
Subject: | Re: pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Date: | 2007-03-08 20:31:07 |
Message-ID: | 200703082031070000@233347734 |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Should this really be backpatched? It'll break existing apps that rely on libpq to call wsastartup for them.
/D
> ------- Original Message -------
> From: mha(at)postgresql(dot)org(MagnusHagander)
> To: pgsql-committers(at)postgresql(dot)org
> Sent: 08/03/07, 19:27:49
> Subject: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSACleanup from DllMain.
>
> Log Message:
> -----------
> Remove unsafe calling of WSAStartup and WSACleanup from DllMain. Move the
> inline cleanup call around so it will be called in the right order, and
> be called on errors.
>
> Per report from Tokuharu Yuzawa.
>
> Tags:
> ----
> REL8_2_STABLE
>
> Modified Files:
> --------------
> pgsql/src/interfaces/libpq:
> bcc32.mak (r1.25.2.1 -> r1.25.2.2)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/bcc32.mak.diff?r1=1.25.2.1&r2=1.25.2.2)
> fe-connect.c (r1.339 -> r1.339.2.1)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-connect.c.diff?r1=1.339&r2=1.339.2.1)
> win32.mak (r1.42.2.1 -> r1.42.2.2)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/win32.mak.diff?r1=1.42.2.1&r2=1.42.2.2)
>
> Removed Files:
> -------------
> pgsql/src/interfaces/libpq:
> libpqdll.c
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/libpqdll.c)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-03-08 20:37:33 | Re: pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Previous Message | Magnus Hagander | 2007-03-08 19:27:49 | pgsql: Remove unsafe calling of WSAStartup and WSACleanup from DllMain. |