Re: Allow \pset to parse "on or off" for boolean values

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Chad Wagner <chad(dot)wagner(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow \pset to parse "on or off" for boolean values
Date: 2007-03-03 17:23:49
Message-ID: 200703031723.l23HNnJ25253@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


I have applied a modified version of your patch, attached. You missed
the cases where \x and \t also need to support boolean constants. The
documentation lumped them all together, and they should be consistent
with the \pset behavior. You will see my change in the modified
do_pset() calls.

Thanks.

---------------------------------------------------------------------------

Chad Wagner wrote:
> This is a TODO item:
>
> o Allow psql \pset boolean variables to set to fixed values, rather
> than toggle
>
>
> Basically allows for:
> test=# \pset expanded on
> Expanded display is on.
> test=# \pset footer off
> Default footer is off.
> test=# \pset footer
> Default footer is on.
> test=# \pset footer
> Default footer is off.
> test=# \pset footer
> Default footer is on.
>
>
> Basically the change is to check if value in do_pset is != NULL to call
> ParseVariableBool to get a true/false and set the value directly, of the
> second parameter is not provided then the "old logic" of toggling is
> supported.
>
> The pset variables that are adjusted are:
> expanded
> numericlocale
> tuples_only
> pager (supports on/off/always now)
> footer

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 9.7 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2007-03-03 17:25:23 Re: Arrays of Complex Types
Previous Message Neil Conway 2007-03-03 17:16:39 Re: resetStringInfo