From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Deadlock with pg_dump? |
Date: | 2007-03-02 18:35:41 |
Message-ID: | 200703021835.l22IZfu03867@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > What are *you* thinking? Yes, that patch has that line, but
> > log_statement and log_min_duration_statement is going to trigger
> > log_min_error_statement so you are going to get the statement printed
> > twice.
>
> What's wrong with that? If a statement triggers two different log
> entries, and both are subject to being annotated with the statement text
> according to log_min_error_statement, I would expect them both to be
> annotated. Doing otherwise will probably break automated log analysis
> tools.
Are people going to be happy that log_statement and
log_min_duration_statement output the statement twice?
test=> SHOW log_min_error_statement;
log_min_error_statement
-------------------------
error
(1 row)
test=> SET log_statement = 'all';
SET
test=> SELECT 1;
?column?
----------
1
(1 row)
Server log has:
LOG: statement: SELECT 1;
STATEMENT: SELECT 1;
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-03-02 18:37:51 | Re: Final version of IDENTITY/GENERATED patch |
Previous Message | Joshua D. Drake | 2007-03-02 18:29:48 | Re: Patch license update to developer's FAQ |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-03-02 18:37:51 | Re: Final version of IDENTITY/GENERATED patch |
Previous Message | Simon Riggs | 2007-03-02 18:34:17 | Re: A little COPY speedup |