| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tsearch in core patch, for inclusion |
| Date: | 2007-02-20 22:21:47 |
| Message-ID: | 200702202221.l1KMLlK14454@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Oleg Bartunov wrote:
> On Tue, 20 Feb 2007, Alvaro Herrera wrote:
>
> > Bruce Momjian wrote:
> >>
> >> FYI, I added this to the patches queue because I think we decided
> >> full-text indexing should be in the core. If I am wrong, please let me
> >> know.
> >
> > One of the objections I remember to this particular implementation was
> > that configuration should be done using functions rather than new syntax
> > in gram.y. This seems a good idea because it avoids bloating the
> > grammar, while still allowing dependency tracking, pg_dump support,
> > syscache support etc.
>
> It's not so big addition to the gram.y, see a list of commands
> http://mira.sai.msu.su/~megera/pgsql/ftsdoc/sql-commands.html.
> SQL commands make FTS syntax clear and follow tradition to manage
> system objects. From the user's side, I'd be very unhappy to configure
> FTS, which can be very complex, using functions. All we want is to
> provide users clear syntax.
I looked at the diff file and the major change in gram.y is the creation
of a new object type FULLTEXT, so you can CREATE, ALTER and DROP
FULLTEXT.
I don't know fulltext administration well enough, so if Oleg says a
function API would be too complex, I am OK with his new parser syntax.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-02-20 22:29:38 | Re: DROP FUNCTION failure: cache lookup failed for relation X |
| Previous Message | Bruce Momjian | 2007-02-20 22:18:22 | Re: patch adding new regexp functions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-02-20 22:29:38 | Re: DROP FUNCTION failure: cache lookup failed for relation X |
| Previous Message | Bruce Momjian | 2007-02-20 22:18:22 | Re: patch adding new regexp functions |