| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, ZeugswetterA(at)spardat(dot)at, andrew(at)dunslane(dot)net, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_restore fails with a custom backup file |
| Date: | 2007-02-19 15:07:12 |
| Message-ID: | 20070219150712.GB29763@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 17, 2007 at 01:28:22PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > I'd also like a comment from at least one other "patch reviewer" that
> > the methods used are good.
>
> It looks reasonable as far as it goes. One thought is that pg_dump
> really should have noticed that it was writing a broken archive.
> On machines where off_t is 32 bits, can't we detect the overflow
> situation?
Tested on MSVC as well, works. Also tested and doesn't break the build
on Linux (which shouldn't be affected at all).
So, patch applied to HEAD and 8.2.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-02-19 15:10:53 | Re: RFC: Temporal Extensions for PostgreSQL |
| Previous Message | Oleg Bartunov | 2007-02-19 15:05:25 | Re: n-gram search function |