From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, "eng(at)intranet(dot)greenplum(dot)com" <eng(at)intranet(dot)greenplum(dot)com> |
Subject: | Re: Avg performance for int8/numeric |
Date: | 2007-02-16 04:55:53 |
Message-ID: | 200702160455.l1G4trs10100@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
I have tested this patch but it generates regression failures.
There was some code drift, so I am attaching an updated version of the
patch, and the regression diffs. The 'four' column is an 'int4' so my
guess is that somehow the wrong aggregate is being called.
---------------------------------------------------------------------------
Mark Kirkwood wrote:
> Neil Conway wrote:
> > On Fri, 2006-11-24 at 11:08 +1300, Mark Kirkwood wrote:
> >> - Modifies do_numeric_accum to have an extra bool parameter and does not
> >> calc sumX2 when it is false.
> >
> > I think it would be clearer to reorganize this function slightly, and
> > have only a single branch on "useSumX2". On first glance it isn't
> > obviously that transdatums[2] is defined (but unchanged) when useSumX2
> > is false.
> >
>
> Right - new patch attached that adds a new function do_numeric_avg_accum
> that only uses N and sum(X). This means I could amend the avg aggregates
> for numeric, int8 to have a initvalues of {0,0}.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/pg/test/regress/regression.diffs | text/x-diff | 646 bytes |
/pgpatches/aggregates | text/x-diff | 7.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-02-16 05:01:15 | Re: WIP patch - INSERT-able log statements |
Previous Message | Hideyuki Kawashima | 2007-02-16 04:06:35 | Re: Acclerating INSERT/UPDATE using UPS |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-02-16 04:58:05 | Re: [GENERAL] ISO week dates |
Previous Message | Tom Lane | 2007-02-16 03:42:00 | Re: WIP patch - INSERT-able log statements |