Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: alexey(dot)zayats(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Date: 2007-02-14 04:45:21
Message-ID: 200702140445.l1E4jLQ17242@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >>> ! if (SOCK_ERRNO != ECONNRESET)
> >>> ! SSL_shutdown(conn->ssl);
> >>
> >> Ummm ... what is this supposed to fix exactly, and what are the odds
>
> > I think the user was getting SIGPIPE on SSL_shutdown() of a closed
> > connection.
>
> It seems moderately improbable that by the time control arrives here,
> errno still has anything to do with the last operation on the SSL
> socket.

Yep, I was wondering that too. It is called SOCK_ERRNO, but in fact it
is just errno on Unix.

I generated the patch just to try to give an example of what the user
might be suggesting. Let's see if anyone wants to research this more.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Pavel Golub 2007-02-14 07:10:54 Re: BUG #2995: PSQLRestore crash and MemoryLeaks!
Previous Message Tom Lane 2007-02-14 04:37:43 Re: Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-02-14 05:01:27 Re: [PERFORM] Direct I/O issues
Previous Message Bruce Momjian 2007-02-14 04:37:49 Re: Avg performance for int8/numeric

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-02-14 05:01:27 Re: [PERFORM] Direct I/O issues
Previous Message Bruce Momjian 2007-02-14 04:37:49 Re: Avg performance for int8/numeric