Re: XML changes broke assert-enabled vcbuild

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: XML changes broke assert-enabled vcbuild
Date: 2007-02-13 16:25:15
Message-ID: 20070213162515.GB13432@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 13, 2007 at 05:23:56PM +0100, Peter Eisentraut wrote:
> Tom Lane wrote:
> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > > From what I can tell, this is because the Assert() puts code (the
> > > do {} loop) *before* the declaration of StringInfoData buf, which
> > > is not permitted.
> >
> > This will fail on every ANSI-C compiler, not just vc. Please fix.
>
> We seem to have very poor coverage of such compilers in the build farm,
> it seems. Is the vcbuild ready to support a regular build farm run
> yet?

Backend-wise, yes. It does require some changes to the buildfarm code itself
(can't call make and such), which I beleive Andrew is working on (when
he has free time).

(the vcregress script I just committed was the final "major step"
towards it, I think)

> It turns out that gcc warns about it anyway. Does anyone have some sort
> of clever recipe to catch warnings more easily than by carefully
> reading the make output or manually grepping build log files or
> something?

Perhaps something we could have the buildfarm do as well, if it can be
automated?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-02-13 16:26:45 Re: [HACKERS] Have psql show current sequnce values - (Resubmission)
Previous Message Peter Eisentraut 2007-02-13 16:23:56 Re: XML changes broke assert-enabled vcbuild