From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Jeremy Drake <pgsql(at)jdrake(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: large object regression tests, take two |
Date: | 2007-02-09 02:30:46 |
Message-ID: | 20070209023046.GX24069@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Bruce Momjian wrote:
>
> Is this patch ready for application?
I think the sed usage would cause problems for the VC++ builds. It
would be good if the files could be reformulated as files in the input,
output or data directories; pg_regress would take care to generate the
files as needed.
> ---------------------------------------------------------------------------
>
> Jeremy Drake wrote:
> > This is the latest version of the large object regression test I have been
> > working on. Note that a prerequisite for this version of the test is the
> > patch I made to psql to make it not output on \lo_* commands in quiet mode
> > is required (also attached, it's small).
> >
> > Sorry that it still makes use of the sed trickery like the copy test does,
> > but:
> >
> > 1) I think the server side lo_(import|export) functions need to be tested
> > as well as the psql variants
> >
> > 2) ISTM that making assumptions about the working directory of psql
> > during
> > the regression tests would open a can of worms, especially wrt VPATH
> > builds where the data files could be in a completely separate tree from
> > the regression tests.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Drake | 2007-02-09 02:33:07 | Re: large object regression tests, take two |
Previous Message | Bruce Momjian | 2007-02-09 02:25:53 | Re: large object regression tests, take two |