Re: pre-vcbuild win32 install docs incorrect

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Neil Conway <neilc(at)samurai(dot)com>, PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pre-vcbuild win32 install docs incorrect
Date: 2007-02-02 18:32:37
Message-ID: 200702021832.l12IWbu02576@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> Neil Conway wrote:
> > On Fri, 2007-02-02 at 10:12 +0100, Magnus Hagander wrote:
> >> This patch fixes a really bad recommendation that's not been removed
> >> from the client-only installation instructions. We removed this
> >> recommendation as of 8.1, but it's still included in the documentation :-(
> >>
> >> Please consider back-patching this into the 8.1 and 8.2 version of the
> >> documentation, as it's something we really don't want people to do.
> >
> > I backpatched this to 8.0, since that branch still has the suggestion.
> > Thanks for the patch.
>
> Thanks.
>
>
> >> *** doc\src\sgml/install-win32.sgml 16 Sep 2006 00:30:14 -0000 1.29
> >> --- doc\src\sgml/install-win32.sgml 2 Feb 2007 09:07:48 -0000
> >
> > Please don't do this :)
>
> You know, I wish I didn't have to ;-) Unfortunately, the only way for me
> to create a patch offline (like this one, on an airplane) is to rsync
> the cvs repository down to the local drive, and run cvsnt on it - since
> cvs does not support offline diff. And the only way to make it not put
> in backslashes instead of slashes is do run the diff in the docs
> directory and not in the root :-(
>
> Does this actually cause a problem for you when you're committing, or is
> is just that it looks bad? Because if it causes a problem I can manually
> edit them out of my patches before I submit.

It causes patch application problems, but I just edit the patchfile to
fix it. I could get fancy and have my patch script fix it too.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-02-02 18:35:17 Re: pre-vcbuild win32 install docs incorrect
Previous Message Magnus Hagander 2007-02-02 18:19:24 Re: pre-vcbuild win32 install docs incorrect