Re: [HACKERS] Win32 WEXITSTATUS too

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: bruce(at)momjian(dot)us
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Date: 2007-01-22 20:02:55
Message-ID: 200701222002.l0MK2tB27727@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

bruce wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Tom Lane wrote:
> > >> It should not be there at all. Do you see URLs in any of our other
> > >> error messages?
> >
> > > Sure, ideally, but how else can we give information about that hex
> > > value?
> >
> > It's not the responsibility of that error message to tell someone to
> > go look up the error number in Microsoft documentation. If they're
> > clueful enough to make any sense of the number beyond the strerror
> > translation we already provide, then they already know where to look.
>
> Well, it took me like 25 minutes to find that list, so it isn't obvious.
> Search for STATUS_CARDBUS_NOT_SUPPORTED, and you get only 75 hits on
> Google, and our URL is #7. One idea Andrew Dunstan had was to print
> descriptions for the most popular values. I asked him to give it a try
> once I applied this patch.
>
> > Even if it were the responsibility of the error message to suggest this,
> > a URL seems far too transient.
>
> It is a URL to the Wine CVS repository, so I assume it will be around for
> a while. One thing we could do is copy that file to a URL on our web
> site and point error messages to that. We could put the file in our CVS
> and point to that too.

FYI, here are the URL's I mention in our source code:

* Wine (URL used in our error messages) -
* http://source.winehq.org/source/include/ntstatus.h
* Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt
* MS SDK - http://www.nologs.com/ntstatus.html

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-01-22 20:07:04 Re: [HACKERS] Win32 WEXITSTATUS too
Previous Message Bruce Momjian 2007-01-22 19:54:39 Re: [HACKERS] Win32 WEXITSTATUS too